Yeah, please leave a todo comment. Currently there's no way to validate this, in the future the DOM side will also have a timeline struct so that it can do this.
Thanks, -Manish Goregaokar On Sat, Apr 27, 2019 at 6:52 AM Josh Bowman-Matthews <j...@joshmatthews.net> wrote: > It's not clear to me how to obtain the information about whether a value > curve is active. I recommend making a pull request with the rest of the > changes and adding a TODO comment about the missing check. > > On 4/26/19 6:01 PM, Srivatsan Narasimhan wrote: > > Hi Josh, > > I wrote the two methods with the help of the links you gave before and it > > is building without anu errors. Now i have some doubts regarding the > > NotSupportedError message. I am not sure when to call that because in the > > method description it says that it should be thrown if any of the > > attributes have any automation curve set using setValueCurveAtTime() and > i > > am not sure how to handle that. Can you help me with that? > > Thanks > > Srivatsan Narasimhan > > > > On Fri, Apr 26, 2019 at 1:37 AM Srivatsan Narasimhan <snara...@ncsu.edu> > > wrote: > > > >> Hi Josh, > >> This is Srivatsan Narasimhan from NCSU currently working on this issue > >> https://github.com/servo/servo/issues/22898 along with my team mates > >> akhilesh, balaji and arjun as a part of the course OODD. I uncommented > the > >> methods in the AudioListener.webidl and currently i am having some > >> issues on writing the methods. I am getting problems with making the two > >> functions a member of the trait AudioListener methods.Is there any > >> reference or a guide that could help me with this? > >> Thanks > >> Srivatsan Narasimhan > >> > > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
