byang wrote: > On Aug 6, 2:16 am, Benjamin Smedberg <[EMAIL PROTECTED]> wrote: >> The problem with your patch is that we typically use a spidermonkey lib that >> is not in the default search path: e.g. not /usr/lib/libjs.so but >> /builds/mozilla-central/js/src/libjs.so > > But my patch is : > +LDFLAGS= -lm -L$(SM_LIBDIR) -l$(SM_NAME) $(SHARED_LINK_FLAGS) > > There is a -L which point out the search directory and this SM_LIBDIR > is set on config.mk.
Unless $(SM_LIBDIR) is /lib, or /usr/lib, or /usr/local/lib, linking will work with your patch, but dehydra will fail at runtime. As Benjamin pointed out, $(SM_LIBDIR) often equals something like '/builds/mozilla-central/js/src'. So your patch will break things. In addition, OS X handles this issue differently. So your patch will need to be platform-aware. -- Sergey Yanovich _______________________________________________ Dev-static-analysis mailing list [email protected] https://lists.mozilla.org/listinfo/dev-static-analysis
