On 5/15/09 4:13 PM, David Humphrey wrote:

> The UI is still very much a work in progress, and I would value
> thoughtful feedback on how you'd like to see it improved.  A couple of

* Personally I'm not a fan of the DHTML popup windows. Especially when I'm
switching between an editor and this page, the popups go away right when I
want them most. I'd prefer either a "real" popup window, a sidebar iframe
that stays permanently open, or even just clicking the link to open in a new
tab.

* I'd like to be able to get to a page with just type information, e.g.
right now I click on nsIImageLoadingContent and there's a popup which lists
the members/etc. But I'd like to be able to link to that type itself (in
IRC, or in docs, etc), or even a particular declaration within the type.

* The "bases" of nsIImageLoadingContent are confusing.
nsIImageLoadingContent derives from imgIDecoderObserver, which derives from
imgIContainerObserver, which derives from nsISupports. But this isn't clear
from the plain list of bases

What I'd really like is an inheritance diagram, much like the ones I made
for nsAString. Otherwise I recommend only listing the direct base, not any
"grand-bases".

* Types which cannot have bases/derived (such as enums) still have tabs for
them in the type view.

http://developer.mozilla.org/en/nsAString_internal

* #include "foo" lines are linkified, but the popups don't have any information

* When clicking on a macro, it's important to say where it was defined.

* Class member declarations such as nsLinkableAccessible::GetStateInternal
currently say:

Name: GetStateInternal(PRUint32*, PRUint32*)
Type Info: nsLinkableAccessible

This is incorrect, or confusing. It should say:

Name: nsLinkableAccessible::GetStateInternal(PRUint32*, PRUint32*)
Member of: nsLinkableAccessible
Return type: nsresult

* You think nsresult comes from zipstub.h... this may be technically true
for some small piece of code, but it's not very useful

* The NSPR types (PRBool) come from obj-foo/dist/include instead of a source
location.

I think I would need links in place to comment more.

--BDS
_______________________________________________
dev-static-analysis mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-static-analysis

Reply via email to