On 08/02/2012 06:37 PM, Benjamin Peterson wrote: > Can tests be written for them, such that engine changes that break > debugging hooks will become immediately known? There are unit tests for the pretty-printers.
I'd suggest that those tests *not* be hooked up to 'make check' to run by default, because they can't be run on OSX and Windows; developers on those platforms could break them, not find out until they hit try, and then be stuck updating debugging tools they don't even use. I could add a configuration flag to add the GDB tests to 'make check', so that developers could 'opt in' to getting trouble reports for the pretty-printers. At least the way I work, I have scripts to run configure for me in the ways I usually need, so this would be easy for me to enable for all my builds. _______________________________________________ dev-tech-js-engine-internals mailing list dev-tech-js-engine-internals@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
