On Friday, July 19, 2013 7:37:28 AM UTC-7, Luke Wagner wrote: > One thing that I think would be really informative is how much time is spent > in C++ stubs called from the baseline/ion. They happen frequently enough > that you probably wouldn't want them to be interleaved on the graph, but > maybe the time could be summed and attached to the enclosing jit block and > then, I dunno, you could change the color of the block to indicate the % of > time in stubs?
1) My objective was more to know which engine is responsible for a particular function, since that is hard to get atm. To know which c++ stub is costly you can just run a c profiler, quite easily. 2) Baseline is "only" doing IC's so it wouldn't really make sense to log if it is in an IC... 3) I think that might be just too costly. This is a tracing logger, so we log everything. Atm this gives a slowdown of atleast 5x (I measured once). If you really want I can do it for ionmonkey, but I'm not sure. If we really want to get more and detailed information, I think we might start to use a sampling profiler instead! On Friday, July 19, 2013 1:27:30 AM UTC-7, David Bruant wrote: > Any chance this could be made into an addon (or just Firefox devtools)? > Something like : reload the page to get the graphs. > How is the information exposed? (so I understand how an addon could grab it > to display it) > > I imagine everyone caring about perf of their website would love to be able > to use such a tool. I can image that. But I think in that case you might just use SPS. It logs more or less the same information. There is only the need to add logging of which engine is used. So that shouldn't be that hard and it would/should be possible to create the same graphs... The person that created SPS may always contact me about this. Why I don't use SPS myself: 1) Because I can use python quite easily to get the information out of it that I want, instead of only the information the addon provides. 2) I don't want to build a browser to test/fix performance in the js-engine. On Friday, July 19, 2013 12:51:55 AM UTC-7, Till Schneidereit wrote: > These graphs look amazing! I'm very much looking forward to doing them for > Shumway: I'm sure we can glean some info from them about how to optimize > that codebase, itself. Cool :D > Three quick comments on the UI: > - the roll out to the bottom from the graph doesn't work, so the > block-tooltips stay around if you move the mouse down from the graph to the > list When it bothers me enough I'll look into it to fix it. Shouldn't be hard. I think it only get removes when going over the background. So if you go over the table they stay. > - it'd be great to be able to sort the scripts list by the various columns Possible now ;) > - I don't know if this easily done, but having invocation counts in > addition to total time would be great for the scripts list Visible now. They will appear as soon as I rebuild the graphs. For GGC I just did, because I added a logger for Minor GC _______________________________________________ dev-tech-js-engine-internals mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
