On Thu, Jun 20, 2013 at 7:21 AM, Till Schneidereit
<[email protected]> wrote:
>
> We still don't have a clear line on how to name handles, both in- and
> outside of the engine.
>
> Options:
> 1. don't use any typedefs at all, so always use (js:: and JS::)Handle<Foo*>
> 2. change the template to the form Handle<Foo>, roughly matching what v8
> does
> 3. use typedefs everywhere, so always use HandleFoo

This thread died, unresolved.  We basically need Luke, as module
owner, to make a decision.

I can offer one new data point.  I've been working on jsapi.h include
minimization (bug 908050).  That's pushed me into the option 1 camp,
because having to deal with the typedefs complicates things -- i.e.
forward declarations for Handle<T> aren't enough;  you have to include
js/RootingAPI.h everywhere as well.

Nick
_______________________________________________
dev-tech-js-engine-internals mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals

Reply via email to