Hi Mike,
Hopefully, my patch doesn't break js engine developers workflow. Please
feel free to test it before landing and report any problem with your
specific workflow.
Thanks for the headsup!
This breaks the custom compilation script that our fuzzing harness uses
for the js shell, crucial for fuzzing compiled shells as well as
autoBisect-ing these compiled shells. This is because it has been
customised to deal with the build configuration in the js directory over
the years, with code that you described as a "horror show"[1], but note
that the some of the build code in js/src wasn't that easy to deal with
anyway.
As a start, I have tried both patches in bug 950298 and they both break
our harness. I'm guessing what is described as "baby step in the
direction of bug 950297"[2] means there is more to come, and I wouldn't
want to patch a fix every time a new patch lands.
I'm willing to migrate our fuzzing harness to the new model, however I'm
out for a work week next week and then PTO(-ish) the following two.
Therefore, may I please suggest using a disposable branch for this?
* Maple branch seems available for now[3]
* The patches can still be tested on the branch
* Occasional merges from m-c are unlikely to bit-rot your patches as the
build files don't get changed very often
* We can avoid breaking the fuzzing harness during this period
* We can test fuzzing harness build changes needed for this on the branch
* We can prepare ourselves when the branch is eventually ready to be
landed on m-c.
I can adapt the harness for Maple branch when the patches there are
about complete and ready for testing to land on m-c.
Does a disposable branch makes sense?
Regards,
-Gary
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=937402#c4
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=950298#c0
[3]
https://wiki.mozilla.org/ReleaseEngineering/DisposableProjectBranches#BOOKING_SCHEDULE
_______________________________________________
dev-tech-js-engine-internals mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
