On Tue, Jan 14, 2014 at 8:17 PM, Andreas Schlegel < [email protected]> wrote:
> It would be nice to attach the code but I'm not sure if bugzilla is a > good place, because I've got a lot of discussion about "why would I do this > thematic?" and I don't think that anybody want that I make a thread which > could be handled as a bug :-) > For me it's a little bit difficult to survey this amount of code of > spidermonkey and where should I place the code or which handler/wrapper > can/have I to change that my changes work. > > Which advantage has bugzilla? > The advantage of having built-in tools to look at your patches. (Those tools aren't fantastic, but certainly good enough for getting specific feedback on your changes.) If you explicitly state that this is an experiment, I don't expect much negative feedback there. Most people who watch js-engine bugs also read this mailing list. > > I was in the IRC channel but at most I get no answer, therefore I leave > the channel. > Yeah, that happens sometimes. :( Try pinging individual people who might be able to help you. Who that might be for a specific area can be found out by looking at who's made changes to the code you're touching, too. > > Am 14.01.2014 19:59, schrieb Till Schneidereit: > > I would at this point very much recommend putting your patches somewhere > they can be looked at by others (ideally attached to a > bugzilla.mozilla.org bug), and then joining the #jsapi channel on IRC. > It's much, much easier and quicker that way. > > > On Tue, Jan 14, 2014 at 7:56 PM, Andreas Schlegel < > [email protected]> wrote: > >> I see the wrapper class is a child of the DirectProxyHandler, which I >> haven't changed until now. Should I change only this class or the >> underlying wrapper? >> >> Am 14.01.2014 19:52, schrieb Andreas Schlegel: >> >> Hello Till, >> >> I think the first answer of my question could be in an other direction. >> I found the CrossCompartmentWrapper, you're speaking from. >> I think I must insert the code there also. >> There are also other wrapper child classes and the wrapper class must I >> insert the method there if I change the CrossCompartmentWrapper? >> >> Am 14.01.2014 19:46, schrieb Till Schneidereit: >> >> On Tue, Jan 14, 2014 at 7:35 PM, Andreas Schlegel < >> [email protected]> wrote: >> >>> My Questions are: >>> >>> Why is the proxy within the global not handled by a >>> ScriptedDirectProxyHandler and which handler is used for? >>> Why are the JSContext and JSRuntime identical, although the two objects >>> should use two different Runtimes? >>> >> >> I don't know the answer to the first question, sorry. >> >> As for the second: you can have arbitrarily many global objects in the >> same runtime. To have two different runtimes, you'd have to create them >> specifically. I don't know if that's even possible in the shell. >> >> The thing that's different for the two globals is the JSCompartment, >> which every global has its own of. >> >> >> >> > > _______________________________________________ dev-tech-js-engine-internals mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
