On 4/6/14, 4:42 AM, Masquerade wrote:
> I am hacking the Spidermonkey source code and have discovered that the
> jsinferinlines.h got a bunch of #include BEFORE the #ifndef include guard.
> Is that what you guys really want? By the way, jsinferinlines.h actually
> includes itself in a cyclic manner:
>
> jsinferinlines.h->
> vm/Stack-inl.h->
> jsscriptinlines.h->
> jsscopeinlines.h->
> jsobjinlines.h->
> jsinferinlines.h
>
> So having includes before the include guard sounds crazy to me.
You're right, this was crazy. We fixed it last year.
*Bug 872416* <https://bugzilla.mozilla.org/show_bug.cgi?id=872416>
-js/src #includes are completely out of control
https://bugzilla.mozilla.org/show_bug.cgi?id=872416
There's now a script that checks for crazy includes. 'make check' runs it.
*Bug 880088* <https://bugzilla.mozilla.org/show_bug.cgi?id=880088>
-Enforce good #include hygiene in SpiderMonkey
https://bugzilla.mozilla.org/show_bug.cgi?id=880088
-j
_______________________________________________
dev-tech-js-engine-internals mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
