Hi, I just landed some patches to remove JS_THREADSAFE and --disable-threadsafe [0]. It's no longer possible to build a non-threadsafe version of SpiderMonkey.
As we're using helper threads for more and more tasks, having #ifdef JS_THREADSAFE in a lot of places became really annoying and cluttered the code (the patch removed > 700 lines). The fuzzers used --disable-threadsafe builds (to make failures easier to reproduce) and they'd often be the first to notice --disable-threadsafe bustage and then had to wait for us to fix it (on m-c). For the fuzzers, there's a new --no-threads shell flag that disables the PJS threads and the helper threads for GC, Ion compilation, source compression etc. This flag has also been added to one of the jit_test.py --tbpl configurations. To build the shell, you can either: (1) Use the --enable-nspr-build configure flag Steve added in bug 975011 [1], to build NSPR as part of the shell. (2) Build and install NSPR yourself and use --with-system-nspr (3) Without any flags, we'll use the NSPR emulation code Bill added [2] (on POSIX platforms). Cheers, Jan [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1031529 [1] https://bugzilla.mozilla.org/show_bug.cgi?id=975011 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=931151 _______________________________________________ dev-tech-js-engine-internals mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
