On 09/25/2014 05:06 PM, Boris Zbarsky wrote: > I was just reading a patch by someone who read > https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/GC_Rooting_Guide > to figure out how to deal with GCThings. > > The result was that they had a Heap<T> that they were not tracing. > > I'm not quite willing to start hacking my own opinions into this page, > but I'd propose the following changes:
I'll do it for you then. ;-) > 1) In the "Summary" section make it clear that Heap<T> has to be > traced. Otherwise it's easy to miss in the one place it's mentioned. Great point! It was the /rooting/ guide, so we didn't focus on tracing. This was a mistake. > 2) Mention PersistentRooted somewhere in here. Good idea! I guess we haven't updated the guide since adding it. > -Boris > _______________________________________________ > dev-tech-js-engine-internals mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals _______________________________________________ dev-tech-js-engine-internals mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
