> Yes, I think we need to do this. However, in addition, we need to add the > #ifdef back for DEBUG. We have to be able to walk back our stack > completely in debug builds to get good assertion information.
That seems reasonable. In fact, this change would actually increase our bug-finding coverage as any problem exposed by preserving ebp is almost certainly a real bug. My only concern is that this will lead to more bugs that don't reproduce in DEBUG builds which is always a pain; but of course that happens a lot anyways for a bunch of reasons, so probably not a big deal. _______________________________________________ dev-tech-js-engine-internals mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
