All right. If you'll take the time to file a bug and attach the patch, I'll
get it checked in.
1. File a bug
* Get an account on bugzilla.mozilla.org
* Click File a Bug, then under "Components" click Core
* Set the Component to "JavaScript engine"
* Fill in the Summary and Description fields, and click Submit Bug.
2. Make the changes
* Make sure you have the latest source code from mozilla-central or
mozilla-inbound
* Add your function to jsapi.h and jsapi.cpp, and make sure it
compiles
3. Upload your patch
* Use `hg diff -U 8 > isregexpobject.patch` to make a patch
* Add it as an attachment to your bug in bugzilla
* Set the "review" flag on the patch to "?" and enter my email
address.
If you run into any problems, let us know.
If you're already quite familiar with mercurial, there's an alternative way
of doing step 3:
3. Upload your patch
* Actually `hg commit` your changes or use `hg qnew` to put them in
MQ,
making sure to include the bug number in your commit message
* Do `./mach mercurial-setup` in the root directory of your mozilla
repo
and let it install bzexport
* Use `hg bzexport -r [email protected]` to upload your patch.
-j
On Wed, Feb 11, 2015 at 7:50 PM, obastemur <[email protected]> wrote:
> Although patching SpiderMonkey is easy/safe? on this case, carrying this
> tiny update from one version to another may not be the best option;
>
> A public method suggestion;
>
> JS_PUBLIC_API(bool)
> JS_IsRegExpObject(JSObject *obj) {
> return obj->is<RegExpObject>();
> }
>
> ** I'm not sure the best method name here. (or JS::HandleObject as a
> parameter, additional checks etc.). Any one of them would work.
>
>
> _______________________________________________
> dev-tech-js-engine-internals mailing list
> [email protected]
> https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
>
_______________________________________________
dev-tech-js-engine-internals mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
