Hello Chris, Yes, the patches and bug report I found, so I added them to the modified Rhino code. Didn't find anything on JSAdapter though, but plenty on the MOP mechanism, and Helma seems to be working just fine. The point of the experiment was really: 1. to keep the Rhino sources and binary separate from any modifications, 2. Track Rhino source changes, and port them back to the modified sources, 3. Allow merging (albeit by hand) from different projects for my own devious purposes.
Putting the modified jar file before the Rhino jar has a couple of advantages too 1. The modified jar is very small - Helma 46KB for example 2. The standard 'approved' Rhino jar can be used by all (other) programs. John On Jul 24, 1:29 pm, Chris Zumbrunn <[EMAIL PROTECTED]> wrote: > On Jul 24, 2008, at 10:13 , John Leach wrote: > > > > > > > On Jul 24, 2:09 am, Norris Boyd <[EMAIL PROTECTED]> wrote: > >> On Jul 22, 12:58 am, John Leach <[EMAIL PROTECTED]> wrote: > > >>> One of the problems I've had in my JavaScript development tools > >>> project Frizionehttp://code.google.com/p/frizione > >>> is that Helma is using a modified version of Rhino, as does > >>> YUICompressor. Unfortunately that means they don't play well > >>> together, > >>> so I had to launch YUICompressor as a process - which seemed > >>> ridiculous. > > >> Ideally we'd just incorporate the changes needed by Helma and > >> YUICompressor back into Rhino itself, provided they're generally > >> useful. Do you know what the nature of the changes to Rhino are? > > > Helma makes some much deeper modifications. It adds a new constructor > > to Token, changes the signature of hasInstance in BaseFunction, adds a > > metaobject to ScriptableObject modifying this class through the has, > > get, put, and delete methods. It also modifies the Parser (adding > > methods) to be able to access the token stream. > > > I'm sure the respective authors can give much more detailed > > information. > > As far as the Helma project is concerned, a list of current diffs/ > patches *normally should be* available here: > > http://dev.helma.org/wiki/Rhino+Bugs+%26+Patches/ > > Also, there is a Rhino bugzilla entry for the Token/Parser patch: > > https://bugzilla.mozilla.org/show_bug.cgi?id=386176 > > I believe the metaobject patch listed on that page is wrong/outdated. > It's the patch for JOMP, but what we actually include in Helma's Rhino > is the JSAdapter patch from the Sun/Phobos project and not JOMP. > > http://groups.google.com/group/mozilla.dev.tech.js-engine.rhino/brows... > > Chris _______________________________________________ dev-tech-js-engine-rhino mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-js-engine-rhino
