On 31/01/2010 20:15, Attila Szegedi wrote:
Hi all,

I just put out the second implementation patch 
at<https://bugzilla.mozilla.org/show_bug.cgi?id=540724>, against current CVS 
HEAD. Check it out if you're interested. I have worked on this for I most of my free 
time I can have for coding in the last 12 days, and have arrived at a much better 
design than what was in the first attempt. I attached a comment to the Bugzilla issue 
describing the design decisions I took. It all feels round to me at the moment. I 
took care to document all classes and interfaces in great detail. I'll proceed with 
writing tests for it, but if you don't mind reviewing and trying bleeding-edge stuff, 
go for it.

Hi Attila and list,

I've started playing with the patch in the context of my ESXX project and while I haven't had time to finish yet I have a couple of questions:

1) I already have a path array in ESXX, which also happens to be a JS array that is searched from the front. However, having two path objects is weired, so I'm wondering if we could either perhaps replace the 'secure' argument with a 'paths' argument (Scriptable) so I can inject mine, or add a method that returns Require's paths object so I can use that one instead?

2) I have a special property named 'esxx.location' that contains the URI of the currently executing file. For this to work I need to know when the Script is executed. It could be solved by making Require.executeModuleScript protected, or better, adding an exec method to ModuleScript.

Comments?

--
---- Martin Blom --------------------------- [email protected] ----
Eccl 1:18                                 http://martin.blom.org/


_______________________________________________
dev-tech-js-engine-rhino mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-js-engine-rhino

Reply via email to