On 09/18/2011 10:33 PM, L. David Baron wrote:
I'd note that you don't want to use PRBool with a :1 bitfield, since
PRBool is a signed type (and therefore a bitfield with one bit holds
the values 0 and -1, or something nasty like that). Use
PRPackedBool instead (which is unsigned).
Ok, thanks.
I'd also note it's definitely worth keeping some of the existing
comments above the macros (and merging them into your new struct
definition).
I left the (updated) definition above the struct, but I could interleave
it with the declarations instead; would you prefer that? I left it at
the top because oftentimes I want to just see the structure, and it
doesn't all fit on one screen when you interleave the comments. I guess
a good compromise would be to comment per related group of declarations
rather than per member or per struct, let me try that.
Here's kindof what I was thinking to change it to. This would involve
touching lots of files... alternatively I could just rearrange the
NS_INLINE_BREAK macros to make that part easier to understand. Thoughts?
Can it be done in more than one step so the pieces are easier to
review?
I don't think it would actually help with the review--the changes don't
really interact across the logical split between completion and break
bits.
Or are you asking me to split the change into
Part I: Rearrange NS_INLINE_BREAK bits and macros
Part II: Convert nsReflowStatus macros to use struct and member functions
? In which case, yes, it can be done, but no I don't want to do it that way
because that means I essentially have to write the patch twice. :)
// Note: Line breaks are currently handled as clears.
Why is this? Are you renaming the current *_BREAK_* stuff to clear
and then introducing new break stuff?
Yes. The current break stuff is all about NS_STYLE_CLEAR, so even though
it handles line breaks (via NS_STYLE_CLEAR_LINE), I thought it best to
name it mClear.
The new break stuff would be pagination breaks.
~fantasai
_______________________________________________
dev-tech-layout mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-layout
