I've landed some patches that remove "Get" from some commonly used methods that never return null, following our convention that such methods have "Get" in the name if and only if they sometimes return null:
https://bugzilla.mozilla.org/show_bug.cgi?id=781360 https://bugzilla.mozilla.org/show_bug.cgi?id=841789 The most likely to bitrot patches is the change of the GetStyle*() functions on nsIFrame and nsStyleContext for getting style structs. It should be straightforward to fix up an existing patch queue using the sed command in: https://bugzilla.mozilla.org/show_bug.cgi?id=781360#c8 (all on one line), e.g., using the command: sed -i -f <file-with-sed-command> <files-to-fix> but be sure to back up your patch queue before doing such things. -David -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla http://www.mozilla.org/ 𝄂 _______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
