On Sunday 2013-07-21 16:20 +1000, Cameron McCormack wrote: > Do nsFrameManagerBase, nsFrameManager and nsCSSFrameConstructor > still need to be separate classes?
The first two, probably not. The third, maybe, if only to keep distinct code separate. > Any reason not to rename nsTextFrameThebes.cpp to nsTextFrame.cpp? No, we've been talking about it for years, along with a list of other file moves. I should probably do that and moving nsStyleConsts.h into layout/style/ ASAP. Another thought I had was maybe: nsIStyleRule -> mozilla::SpecifiedStyle nsIStyleRuleProcessor -> mozilla::SpecifiedStyleSource though I'm far from sold on it yet. Also, I realize that we've had some confusion from the XUL layout methods, originally separate on nsIBox, that have been merged into nsIFrame. Perhaps those should have a XUL prefix (e.g., XULLayout(), XULBorderAndPadding(), etc.). See the big chunk of nsIFrame.h between "BOX LAYOUT METHODS" and "END OF BOX LAYOUT METHODS". -David -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla http://www.mozilla.org/ 𝄂 _______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
