Hi Christian, necko-folk, Last week I read an update from the firefox module team about their code review policy in browser/* - https://wiki.mozilla.org/Firefox/Code_Review
I like it very much because it addresses who the reviewers are, what they are responsible for, what a r+ means, and what is not required for a r+. All of these things have confused me about necko from time to time. ok, all the time if I'm being honest. I would like to propose we adopt a policy like the browser/* one above. I'd be happy with that exact policy actually but something else that clearly addresses the same points and that we can all get behind would be fine too. We are sort of de-facto doing some of these things - especially the who-are-the-reviewers bits. It would be good to write it down, but I'm most interested in defining what is and what isn't part of a review - that seems to be a more mercurial (ha!) definition. I'd love to hear from everyone, but especially Christian as module owner. What do you think? -Pat _______________________________________________ dev-tech-network mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-network
