Hello Thomas, Unfortunately, for reasons I don't quite understand just yet, I have not been receiving your notes via the abdera-dev list. Let me try to answer your questions...
1. Yes, patches for any part of this would be fantastic, 2. The WrappedEntryObject idea sounds just fine. I'll take a look at the specific patch on monday. 3. Patches for code style updates are fine as well. 4. Ant: I'm +0 on switching to git, either way is just fine for me. 5. Good catch on the abdera-example rename. Will fix that on Monday when I get a chance to dig into the code. 6. The nice thing about the Constants class is that it keeps all those pesky, commonly used QName objects together and instantiates them all at once. those are used extensively throughout the codebase so before eliminating it, we need to see a counter-proposal that does not increase complexity for developers. 7. Renaming the Generator to Builder is fine, but I think the use of Supplier is fine as is. Introducing a new Builder interface where the only real difference is the name of the method to get the thing that is built seems pointless to me. 8. Regarding the point on inheritance... you're right. The server-side code suffers from this the most. I've been wanting to see a complete overhaul of the server side stuff for a while but just did not have the bandwidth to do the complete rework that I had wanted. Any simplifications to this that you think can be made would be fantastic. Hopefully that addresses all the concerns and questions. I'm going to be able to return to abdera2 todo items on Monday to work on test cases, etc and will take a look at any submitted patches. Thanks for jumping in on this Thomas, it's very helpful to have someone so engaged. - James On Fri, Jan 27, 2012 at 12:25 PM, James Snell <[email protected]> wrote: > Honestly I've been buried all week. Taking a look now, thanks for the > reminder. > > On Fri, Jan 27, 2012 at 2:41 AM, ant elder <[email protected]> wrote: >> Did you find his emails? He seems keen to help and I'd like to >> encourage him but as you've written all this code i think you're best >> to respond to some of his emails? >> >> ...ant >> >> On Wed, Jan 25, 2012 at 8:23 PM, ant elder <[email protected]> wrote: >>> http://mail-archives.apache.org/mod_mbox/abdera-dev/201201.mbox/browser >>> >>> ...ant >>> >>> On Wed, Jan 25, 2012 at 8:21 PM, James Snell <[email protected]> wrote: >>>> Hmm no I haven't seen those.. :-/ which list is he posting to? >>>> >>>> On Wed, Jan 25, 2012 at 12:03 PM, ant elder <[email protected]> wrote: >>>>> Hi James, I just ask as once you said you hadn't seen an email from me >>>>> to the dev list so maybe you don't get everything, Thomas Koch has >>>>> been asking a lot of questions, i wondered if you were getting those? >>>>> >>>>> ...ant
