----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5684/#review8832 -----------------------------------------------------------
/branches/1.4/src/server/src/main/java/org/apache/accumulo/server/master/tableOps/BulkImport.java <https://reviews.apache.org/r/5684/#comment18744> Prefer for the master to expose the FileSystem it is using. /branches/1.4/src/server/src/main/java/org/apache/accumulo/server/master/tableOps/BulkImport.java <https://reviews.apache.org/r/5684/#comment18745> needs try {} finally { out.close(); } /branches/1.4/src/server/src/main/java/org/apache/accumulo/server/zookeeper/DistributedWorkQueue.java <https://reviews.apache.org/r/5684/#comment18746> Could use a short summary. Suggest: Worker processes watch a zookeeper node for tasks to be performed. After getting an exclusive lock on the node, the worker will perform the task. - Eric Newton On July 3, 2012, 12:38 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5684/ > ----------------------------------------------------------- > > (Updated July 3, 2012, 12:38 p.m.) > > > Review request for accumulo. > > > Description > ------- > > A patch that fixes the issue of failed bulk imports being copied through the > master. > > > This addresses bug ACCUMULO-409. > https://issues.apache.org/jira/browse/ACCUMULO-409 > > > Diffs > ----- > > > /branches/1.4/src/core/src/main/java/org/apache/accumulo/core/Constants.java > 1356670 > > /branches/1.4/src/core/src/main/java/org/apache/accumulo/core/conf/Property.java > 1356670 > > /branches/1.4/src/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooUtil.java > 1356670 > > /branches/1.4/src/server/src/main/java/org/apache/accumulo/server/client/BulkImporter.java > 1356670 > > /branches/1.4/src/server/src/main/java/org/apache/accumulo/server/master/tableOps/BulkImport.java > 1356670 > > /branches/1.4/src/server/src/main/java/org/apache/accumulo/server/tabletserver/BulkFailedCopyProcessor.java > PRE-CREATION > > /branches/1.4/src/server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java > 1356670 > > /branches/1.4/src/server/src/main/java/org/apache/accumulo/server/zookeeper/DistributedWorkQueue.java > PRE-CREATION > > /branches/1.4/src/server/src/main/java/org/apache/accumulo/server/zookeeper/IZooReaderWriter.java > 1356670 > > /branches/1.4/src/server/src/main/java/org/apache/accumulo/server/zookeeper/ZooReaderWriter.java > 1356670 > /branches/1.4/test/system/test4/bulk_import_test.sh 1356670 > > Diff: https://reviews.apache.org/r/5684/diff/ > > > Testing > ------- > > > Thanks, > > kturner > >
