----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6138/#review9885 -----------------------------------------------------------
/trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java <https://reviews.apache.org/r/6138/#comment21011> Any reason why we don't have a a non-static version of ColumnFQ.fetch? We could simply write: METADATA_PREV_ROW_COLUMN.fetch(metaScanner); /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java <https://reviews.apache.org/r/6138/#comment21012> Let's make the Master's getConnector method public, so we can avoid calls to HdfsZooInstance.getInstance(). /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java <https://reviews.apache.org/r/6138/#comment21013> maybe use try/finally to avoid leaking resources when errors occur /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java <https://reviews.apache.org/r/6138/#comment21014> if we are going to collect timing information, we should probably trace it, too. Oh, wait... this is a randomwalk test. Nevermind. :-) - Eric Newton On July 31, 2012, 9:51 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6138/ > ----------------------------------------------------------- > > (Updated July 31, 2012, 9:51 p.m.) > > > Review request for accumulo. > > > Description > ------- > > A patch to add import and export table to Accumulo > > > This addresses bug ACCUMULO-456. > https://issues.apache.org/jira/browse/ACCUMULO-456 > > > Diffs > ----- > > /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java > 1366092 > /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java > 1366092 > /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java > 1366092 > > /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java > PRE-CREATION > /trunk/core/src/main/thrift/client.thrift 1366092 > /trunk/core/src/main/thrift/master.thrift 1366092 > > /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java > 1366092 > /trunk/docs/examples/README.export PRE-CREATION > /trunk/docs/src/user_manual/chapters/table_configuration.tex 1366092 > /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java > 1366092 > > /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java > 1366092 > > /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java > PRE-CREATION > > /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java > PRE-CREATION > > /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java > PRE-CREATION > /trunk/test/system/randomwalk/conf/modules/Shard.xml 1366092 > > Diff: https://reviews.apache.org/r/6138/diff/ > > > Testing > ------- > > > Thanks, > > kturner > >
