I don't see why it should be, but I see no harm
On Wed, Jan 2, 2013 at 4:32 PM, Keith Turner <[email protected]> wrote: > On Wed, Jan 2, 2013 at 3:33 PM, <[email protected]> wrote: > > Author: vines > > Date: Wed Jan 2 20:33:46 2013 > > New Revision: 1428004 > > > > URL: http://svn.apache.org/viewvc?rev=1428004&view=rev > > Log: > > ACCUMULO-832 - accumulo script will now make ACCUMULO_LOG_DIR if it does > not exist. Explicit check for ACCUMULO_LOG_DIR to be set > > > > > > Modified: > > accumulo/trunk/bin/accumulo > > > > Modified: accumulo/trunk/bin/accumulo > > URL: > http://svn.apache.org/viewvc/accumulo/trunk/bin/accumulo?rev=1428004&r1=1428003&r2=1428004&view=diff > > > ============================================================================== > > --- accumulo/trunk/bin/accumulo (original) > > +++ accumulo/trunk/bin/accumulo Wed Jan 2 20:33:46 2013 > > @@ -71,16 +71,24 @@ XML_FILES=${ACCUMULO_HOME}/conf > > > > CLASSPATH=${XML_FILES}:${START_JAR}:${COMMONS_JCI_JARS}:${COMMONS_VFS_JARS}:${HADOOP_CLASSPATH} > > > > if [ -z $JAVA_HOME -o ! -d $JAVA_HOME ]; then > > - echo "JAVA_HOME is not set. Please make sure it's set globally or > in conf/accumulo-env.sh" > > - exit 1 > > + echo "JAVA_HOME is not set. Please make sure it's set globally or in > conf/accumulo-env.sh" > > + exit 1 > > fi > > if [ -z $HADOOP_HOME -o ! -d $HADOOP_HOME ]; then > > - echo "HADOOP_HOME is not set. Please make sure it's set globally > or in conf/accumulo-env.sh" > > - exit 1 > > + echo "HADOOP_HOME is not set. Please make sure it's set globally or > in conf/accumulo-env.sh" > > + exit 1 > > fi > > if [ -z $ZOOKEEPER_HOME -o ! -d $ZOOKEEPER_HOME ]; then > > - echo "ZOOKEEPER_HOME is not set. Please make sure it's set > globally or in conf/accumulo-env.sh" > > - exit 1 > > + echo "ZOOKEEPER_HOME is not set. Please make sure it's set globally > or in conf/accumulo-env.sh" > > + exit 1 > > +fi > > +if [ -z $ACCUMULO_LOG_DIR ]; then > > + echo "ACCUMULO_LOG_DIR is not set. Please make sure it's set > globally or in conf/accumulo-env.sh" > > + exit 1 > > +fi > > + > > +if [ ! -d "$ACCUMULO_LOG_DIR" ]; then > > + mkdir $ACCUMULO_LOG_DIR; > > should this use "mkdir -p"? > > > fi > > > > #Export the variables just in case they are not exported > > > > > -- Cheers ~John
