Also, I'd love to have the accumulo-maven-plugin (in progress, ACCUMULO-1030) work on Windows.
-- Christopher L Tubbs II http://gravatar.com/ctubbsii On Fri, Jun 14, 2013 at 11:39 PM, Christopher <ctubb...@apache.org> wrote: > I do not think we should maintain separate profiles. If we were to > vote on that, I'd vote against for the following reasons: > > 1) It adds build complexity and is difficult to maintain > 2) Restricting tests like this has the potential to mask serious bugs > 3) It doesn't address the underlying compatibility problems > > As an alternative, I'd rather see the code (or the tests) improved so > they function better in Windows. If it means that some code needs to > function differently on one environment than another, then the code > should do that check itself and behave accordingly. I don't see why > some blocks of code can't have a check for the OS, when absolutely > necessary (I suspect often it isn't necessary... there's probably more > platform-independent ways of doing what is failing): > > if (System.getProperty("os.name").toLowerCase().contains("windows")) { > // do stuff on windows > } else { > // do other stuff > } > > > -- > Christopher L Tubbs II > http://gravatar.com/ctubbsii > > > On Fri, Jun 14, 2013 at 9:59 PM, David Medinets > <david.medin...@gmail.com> wrote: >> In March there was little enthusiasm for this change. However, since then >> the MiniAccumulo cluster has been ported to Windows. If people want the MAC >> on Windows, then the whole system should be compilable ... if not >> executable. >> >> http://affy.blogspot.com/2013/03/running-accumulo-unit-tests-on-windows.htmllists >> the the non-working tests; at least those that did not work in March. >> >> Can we vote on this change? Most of the work has already been done. It >> seems harmless.
