----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16305/#review30513 -----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java <https://reviews.apache.org/r/16305/#comment58426> Does this (or any of the "already in UTF-8 bytes" methods) validate that the bytes are actually UTF-8? If not, I would include a warning. core/src/main/java/org/apache/accumulo/core/security/Authorizations.java <https://reviews.apache.org/r/16305/#comment58423> Can we get a TODO or a follow on Jira that this shouldn't be making a copy? core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java <https://reviews.apache.org/r/16305/#comment58425> I think you'd be in rights to fix all the within-javadocs whitespace errors, like this one. core/src/main/java/org/apache/accumulo/core/security/Credentials.java <https://reviews.apache.org/r/16305/#comment58427> Consider something more informative. e.g. @param principal A unique identifier for the entity (e.g. a user or service) authorized for these credentials. core/src/main/java/org/apache/accumulo/core/security/Credentials.java <https://reviews.apache.org/r/16305/#comment58428> Consider something more informative. e.g. Gets the unique identifier for the entity associated with these credentials. This could be e.g. a user name or system application. core/src/main/java/org/apache/accumulo/core/security/Credentials.java <https://reviews.apache.org/r/16305/#comment58429> Consider something more informative. e.g. Gets the authentication token used to prove that the principal for these credentials can been properly verified. core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java <https://reviews.apache.org/r/16305/#comment58430> Can we make this language stronger? maybe use RFC MAY, MUST, and MUST NOT language? core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java <https://reviews.apache.org/r/16305/#comment58431> Can you add a brief description of the permissions, or are they documented somewhere else we can link to? core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java <https://reviews.apache.org/r/16305/#comment58432> Can we make this language stronger? maybe use RFC MAY, MUST, and MUST NOT language? core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java <https://reviews.apache.org/r/16305/#comment58433> Can you add a brief description of the permissions, or are they documented somewhere else we can link to? core/src/main/java/org/apache/accumulo/core/security/TablePermission.java <https://reviews.apache.org/r/16305/#comment58435> Can we make this language stronger? maybe use RFC MAY, MUST, and MUST NOT language? core/src/main/java/org/apache/accumulo/core/security/TablePermission.java <https://reviews.apache.org/r/16305/#comment58434> Can you add a brief description of the permissions, or are they documented somewhere else we can link to? - Sean Busbey On Dec. 16, 2013, 8:22 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16305/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 8:22 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2030 > https://issues.apache.org/jira/browse/ACCUMULO-2030 > > > Repository: accumulo > > > Description > ------- > > Javadoc for o.a.a.core.security. > > I'll wait to submit the patch until a committer +1 or three business days > inactivity, whichever happens first. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java > 041bf3c > core/src/main/java/org/apache/accumulo/core/security/Authorizations.java > 5cecefb > core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java > bd16b84 > core/src/main/java/org/apache/accumulo/core/security/Credentials.java > 45708a8 > > core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java > fb6847b > core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java > 6bdb8e6 > core/src/main/java/org/apache/accumulo/core/security/TablePermission.java > 912b5fb > > core/src/main/java/org/apache/accumulo/core/security/VisibilityConstraint.java > ae29cc7 > > core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java > 45b595f > > core/src/main/java/org/apache/accumulo/core/security/VisibilityParseException.java > 2f46dc9 > > Diff: https://reviews.apache.org/r/16305/diff/ > > > Testing > ------- > > mvn javadoc:javadoc returns no errors or warnings for these classes. > > > Thanks, > > Bill Havanki > >
