----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16857/#review31742 -----------------------------------------------------------
Ship it! Since you didn't use cherry-pick, I expect that you took the time to ensure that you pulled back the changes from the commits for each issue. Also, please be sure to add something to the commit message that outlines that "these changes are a backport from blah blah blah", or similar. - Josh Elser On Jan. 14, 2014, 2:09 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16857/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2014, 2:09 p.m.) > > > Review request for accumulo and Josh Elser. > > > Bugs: ACCUMULO-2182 > https://issues.apache.org/jira/browse/ACCUMULO-2182 > > > Repository: accumulo > > > Description > ------- > > Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / > ACCUMULO-2106. This review request is a combined diff; I have a patch file > with separate commits for -1123 and -2104/-2106. > > These backports were done "by hand" rather than cherry-picking, so > double-checking against the original tickets is most welcome. > > > Diffs > ----- > > > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java > 1c73414 > > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java > fe406e7 > > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java > d7f65ae > > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java > 429c8cd > > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java > afefee8 > > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java > 52a4672 > > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java > e0b8deb > > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java > 5714893 > > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java > b91c81c > > Diff: https://reviews.apache.org/r/16857/diff/ > > > Testing > ------- > > Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, > Shard, Multitable. Security test running 17 hours so far without failure due > to BAD_CREDENTIALS, which is what -1123 fixes. > > > Thanks, > > Bill Havanki > >
