> On Jan. 21, 2014, 2:48 p.m., Mike Drob wrote: > > src/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java, > > line 289 > > <https://reviews.apache.org/r/17129/diff/1/?file=432897#file432897line289> > > > > Should check for debug enabled, not trace.
The example configurations we ship out of the box (and thus what people usually use) always have DEBUG enabled (they just change what logs things go to). I wanted to make sure this wasn't normally logged with a stack trace, since there isn't an error and including it is likely to confuse the user. Note that we log at debug level in both cases (again so that our common configs will see one of the two output messages in the debug log) - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17129/#review32361 ----------------------------------------------------------- On Jan. 20, 2014, 7:18 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17129/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2014, 7:18 p.m.) > > > Review request for accumulo and Eric Newton. > > > Bugs: ACCUMULO-2213 > https://issues.apache.org/jira/browse/ACCUMULO-2213 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2213 Make writer recovery in the Tracer more robust. > > * Adds optional logging to TSBW closure so we can better instrument long > run tests to look for problems. > * Cleans up writer reseting in the TraceServer, avoids overly broad > catching. > * tones down log levels in TraceServer to WARN because trace information > is transient and we retry everything. > > > Diffs > ----- > > > src/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java > e18f3f96f4e0959b975399921bb7d7958c561220 > src/server/src/main/java/org/apache/accumulo/server/trace/TraceServer.java > 4d89e9c13f89e71e674875db32cf267e045d6131 > > Diff: https://reviews.apache.org/r/17129/diff/ > > > Testing > ------- > > running on cluster with injected failures now > > > Thanks, > > Sean Busbey > >
