> On Jan. 21, 2014, 7:42 p.m., Bill Havanki wrote: > > src/core/src/main/java/org/apache/accumulo/core/util/AddressUtil.java, > > lines 76-79 > > <https://reviews.apache.org/r/17132/diff/3/?file=433534#file433534line76> > > > > I think this bit shouldn't be in the refactored method. The method > > should simply figure out a TTL value and return it. The calling code in > > ZooSession can decide that it can't recover from a -1. Seems cleaner that > > way.
I thought that as well, but the other location that needs to call this same method ends up needing to do the exact same check, complete with verbose error message. It seemed better to avoid the duplication. thoughts? - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17132/#review32408 ----------------------------------------------------------- On Jan. 21, 2014, 6:12 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17132/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 6:12 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2224 > https://issues.apache.org/jira/browse/ACCUMULO-2224 > > > Repository: accumulo > > > Description > ------- > > * retries if host is not found, up to 2xZK timeout (same as other > IOExceptions), rather than bailing on any host name problem. > * adds utility method for getting the max time the JVM will cache host > failures > * add test for said method > > > Diffs > ----- > > src/core/src/main/java/org/apache/accumulo/core/util/AddressUtil.java > 0b821289d2ea6739e664b33c5db3d5050306f7fe > src/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooSession.java > e64f0c52e51b9339930f6a70564fcc48031df687 > src/core/src/test/java/org/apache/accumulo/core/util/AddressUtilTest.java > f46f4277d8c12693e1e32cfa6870a88f96742753 > src/core/src/test/resources/log4j.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/17132/diff/ > > > Testing > ------- > > functional + ci in progress > > > Thanks, > > Sean Busbey > >
