-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18365/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 1:24 p.m.)
Review request for accumulo.
Changes
-------
Changed TraceProxy to use a logger. Expanded try/catch to include the other
call to method.invoke() and added another unit test to verify.
Bugs: ACCUMULO-2390
https://issues.apache.org/jira/browse/ACCUMULO-2390
Repository: accumulo
Description
-------
ACCUMULO-2390 InvocationTargetEx in TraceProxy
Handle InvocationTargetException specifically in TraceProxy, instead
of letting it get propogated up the call stack. In some cases this is
very bad as it turned into an UndeclaredThrowableException and made
debugging more difficult than necessary.
Added unit test to verify behaviour.
Diffs (updated)
-----
src/trace/src/main/java/org/apache/accumulo/cloudtrace/instrument/TraceProxy.java
67c4463429fdacdb4aae1d07d5256a5a4f077552
src/trace/src/test/java/org/apache/accumulo/cloudtrace/instrument/TracerTest.java
30b62f9f7d4c0a047a33fd0244b3acd57733b5b1
Diff: https://reviews.apache.org/r/18365/diff/
Testing
-------
Unit tests run.
Thanks,
Mike Drob
