----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18625/#review35783 -----------------------------------------------------------
test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66524> What are you planning on changing before submitting this as a patch? test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66525> Would be nice to place hadoop and zookeeper setup in seprate scripts, and just pass this script info about running hadoop and zookeeper instances. This makes it easier to use this script with custom configured hadoop and zookeeper instances. test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66526> Would be nice to put this test in a subdir, like system/test/upgrade and under that have a file like system/test/upgrade/conf/15/accumulo_site.template.xml test/system/upgrade_test.sh <https://reviews.apache.org/r/18625/#comment66527> would be nice to put these test functions in a subdir and have this script execute each function in the subdir. I am not sure of the best way to do this w/ bash scripts. With java or python each test script could implement and interface and have multiple methods like runPreUpgradeTest() and runPostUpgradeTest() - kturner On Feb. 28, 2014, 2:23 p.m., John McNamee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18625/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 2:23 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2145 > https://issues.apache.org/jira/browse/ACCUMULO-2145 > > > Repository: accumulo > > > Description > ------- > > This is still a work in progress. > > The framework would configure the Accumulo versions, HDFS, zookeeper, and > which test to run. > Runs a set of upgrade tests. > > > Diffs > ----- > > test/system/upgrade_test.sh 6259e1c > > Diff: https://reviews.apache.org/r/18625/diff/ > > > Testing > ------- > > > Thanks, > > John McNamee > >
