> On Feb. 28, 2014, 8:37 a.m., Mike Drob wrote: > > bin/bootstrap_config.sh, line 48 > > <https://reviews.apache.org/r/18438/diff/1/?file=502514#file502514line48> > > > > Should also respect the ACCUMULO_CONF_DIR environment variable that > > other processes can use.
Mike, I don't think this is valid. This CONF_DIR is unrelated to the bin/accumulo ACCUMULO_CONF_DIR. This is a variable that is used internally, for the output location. This script *creates* the accumulo-env.sh script that contains the ACCUMULO_CONF_DIR variable for bin/accumulo, so it cannot depend on it. It could interpret it from the user's environment, but I think that's making too many assumptions. This script has the option to specify an alternate output directory, but uses $ACCUMULO_HOME/conf by default. Its similarity to the ACCUMULO_CONF_DIR is coincidental. It's just an internal variable name for the default output location for this script. - Christopher ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18438/#review35778 ----------------------------------------------------------- On Feb. 27, 2014, 9:52 a.m., John McNamee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18438/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 9:52 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1395 > https://issues.apache.org/jira/browse/ACCUMULO-1395 > > > Repository: accumulo > > > Description > ------- > > Generate example configuration > > > Diffs > ----- > > assemble/pom.xml 5a1d8e3 > assemble/src/main/assemblies/component.xml fa53d5e > bin/bootstrap_config.sh be472d3 > conf/accumulo.policy.example 2964f06 > conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6 > conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d > conf/examples/1GB/native-standalone/accumulo-site.xml b68059c > conf/examples/1GB/native-standalone/auditLog.xml 9b7987e > conf/examples/1GB/native-standalone/gc 63fb8bb > conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90 > conf/examples/1GB/native-standalone/log4j.properties a4bcb2e > conf/examples/1GB/native-standalone/masters 63fb8bb > conf/examples/1GB/native-standalone/monitor 63fb8bb > conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4 > conf/examples/1GB/native-standalone/slaves 63fb8bb > conf/examples/1GB/native-standalone/tracers 63fb8bb > conf/examples/1GB/standalone/accumulo-env.sh 8b904ac > conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d > conf/examples/1GB/standalone/accumulo-site.xml 1bca857 > conf/examples/1GB/standalone/auditLog.xml 9b7987e > conf/examples/1GB/standalone/gc 63fb8bb > conf/examples/1GB/standalone/generic_logger.xml 4d2af90 > conf/examples/1GB/standalone/log4j.properties a4bcb2e > conf/examples/1GB/standalone/masters 63fb8bb > conf/examples/1GB/standalone/monitor 63fb8bb > conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4 > conf/examples/1GB/standalone/slaves 63fb8bb > conf/examples/1GB/standalone/tracers 63fb8bb > conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb > conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d > conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff > conf/examples/2GB/native-standalone/auditLog.xml 9b7987e > conf/examples/2GB/native-standalone/gc 63fb8bb > conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90 > conf/examples/2GB/native-standalone/log4j.properties a4bcb2e > conf/examples/2GB/native-standalone/masters 63fb8bb > conf/examples/2GB/native-standalone/monitor 63fb8bb > conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4 > conf/examples/2GB/native-standalone/slaves 63fb8bb > conf/examples/2GB/native-standalone/tracers 63fb8bb > conf/examples/2GB/standalone/accumulo-env.sh feba48c > conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d > conf/examples/2GB/standalone/accumulo-site.xml c9e0309 > conf/examples/2GB/standalone/auditLog.xml 9b7987e > conf/examples/2GB/standalone/gc 63fb8bb > conf/examples/2GB/standalone/generic_logger.xml 4d2af90 > conf/examples/2GB/standalone/log4j.properties a4bcb2e > conf/examples/2GB/standalone/masters 63fb8bb > conf/examples/2GB/standalone/monitor 63fb8bb > conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4 > conf/examples/2GB/standalone/slaves 63fb8bb > conf/examples/2GB/standalone/tracers 63fb8bb > conf/examples/3GB/native-standalone/accumulo-env.sh be72992 > conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d > conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3 > conf/examples/3GB/native-standalone/auditLog.xml 9b7987e > conf/examples/3GB/native-standalone/gc 63fb8bb > conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90 > conf/examples/3GB/native-standalone/log4j.properties a4bcb2e > conf/examples/3GB/native-standalone/masters 63fb8bb > conf/examples/3GB/native-standalone/monitor 63fb8bb > conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4 > conf/examples/3GB/native-standalone/slaves 63fb8bb > conf/examples/3GB/native-standalone/tracers 63fb8bb > conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a > conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d > conf/examples/3GB/standalone/accumulo-site.xml a127cbd > conf/examples/3GB/standalone/auditLog.xml 9b7987e > conf/examples/3GB/standalone/gc 63fb8bb > conf/examples/3GB/standalone/generic_logger.xml 4d2af90 > conf/examples/3GB/standalone/log4j.properties a4bcb2e > conf/examples/3GB/standalone/masters 63fb8bb > conf/examples/3GB/standalone/monitor 63fb8bb > conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4 > conf/examples/3GB/standalone/slaves 63fb8bb > conf/examples/3GB/standalone/tracers 63fb8bb > conf/examples/512MB/native-standalone/accumulo-env.sh e02b524 > conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d > conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2 > conf/examples/512MB/native-standalone/auditLog.xml 9b7987e > conf/examples/512MB/native-standalone/gc 63fb8bb > conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90 > conf/examples/512MB/native-standalone/log4j.properties a4bcb2e > conf/examples/512MB/native-standalone/masters 63fb8bb > conf/examples/512MB/native-standalone/monitor 63fb8bb > conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4 > conf/examples/512MB/native-standalone/slaves 63fb8bb > conf/examples/512MB/native-standalone/tracers 63fb8bb > conf/examples/512MB/standalone/accumulo-env.sh 457e1d3 > conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d > conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7 > conf/examples/512MB/standalone/auditLog.xml 9b7987e > conf/examples/512MB/standalone/gc 63fb8bb > conf/examples/512MB/standalone/generic_logger.xml 4d2af90 > conf/examples/512MB/standalone/log4j.properties a4bcb2e > conf/examples/512MB/standalone/masters 63fb8bb > conf/examples/512MB/standalone/monitor 63fb8bb > conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4 > conf/examples/512MB/standalone/slaves 63fb8bb > conf/examples/512MB/standalone/tracers 63fb8bb > conf/examples/crypto/accumulo-site.xml a7e5c54 > conf/examples/crypto/readme.txt c638b6e > conf/examples/vfs-classloader/accumulo-site.xml ea95ea2 > conf/templates/accumulo-env.sh PRE-CREATION > conf/templates/accumulo-metrics.xml PRE-CREATION > conf/templates/accumulo-site.xml PRE-CREATION > conf/templates/accumulo.policy.example PRE-CREATION > conf/templates/gc PRE-CREATION > conf/templates/generic_logger.xml PRE-CREATION > conf/templates/log4j.properties PRE-CREATION > conf/templates/masters PRE-CREATION > conf/templates/monitor PRE-CREATION > conf/templates/monitor_logger.xml PRE-CREATION > conf/templates/slaves PRE-CREATION > conf/templates/tracers PRE-CREATION > > Diff: https://reviews.apache.org/r/18438/diff/ > > > Testing > ------- > > > Thanks, > > John McNamee > >