----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19368/#review37612 -----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/util/Stat.java <https://reviews.apache.org/r/19368/#comment69229> shouldn't something be done w/ mean and q? core/src/test/java/org/apache/accumulo/core/util/StatTest.java <https://reviews.apache.org/r/19368/#comment69232> need to test clear method core/src/test/java/org/apache/accumulo/core/util/StatTest.java <https://reviews.apache.org/r/19368/#comment69231> maybe have a data set w/ single data point. core/src/test/java/org/apache/accumulo/core/util/StatTest.java <https://reviews.apache.org/r/19368/#comment69230> why not check large.sum()? - kturner On March 18, 2014, 7:44 p.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19368/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 7:44 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2494 > https://issues.apache.org/jira/browse/ACCUMULO-2494 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2494 Fix calcualtion of stdev > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/util/Stat.java > e65265c6decde47ef229377653112a677fef8112 > core/src/test/java/org/apache/accumulo/core/util/StatTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/19368/diff/ > > > Testing > ------- > > Unit tests results compared with calculations from Wolfram Alpha. > > > Thanks, > > Mike Drob > >
