----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20636/#review41382 -----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java <https://reviews.apache.org/r/20636/#comment74801> Unused import core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java <https://reviews.apache.org/r/20636/#comment74802> Unused import core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java <https://reviews.apache.org/r/20636/#comment74803> Unused imports core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java <https://reviews.apache.org/r/20636/#comment74805> Unused imports core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java <https://reviews.apache.org/r/20636/#comment74822> For all these places, it seems like a stronger statement can be made. Such as "Do Not Use". Stating intent is one thing. Actually advising against using it is better. core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java <https://reviews.apache.org/r/20636/#comment74807> Unused import core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java <https://reviews.apache.org/r/20636/#comment74808> Unused import core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java <https://reviews.apache.org/r/20636/#comment74809> Unused import core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java <https://reviews.apache.org/r/20636/#comment74810> Unused imports core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java <https://reviews.apache.org/r/20636/#comment74811> Unused Import core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java <https://reviews.apache.org/r/20636/#comment74823> Credentials isn't public API. We should not advise people use that. This whole class should be deprecated. Nobody should be using it. core/src/main/java/org/apache/accumulo/core/security/Credentials.java <https://reviews.apache.org/r/20636/#comment74818> I'm not a fan of baking in more thrift/RPC stuff into the rest of the code. This isn't serious, because Credentials is not public API (yet), but I'm opposed to it. I'd rather just inline these than modify Credentials. core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java <https://reviews.apache.org/r/20636/#comment74812> Unused import core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java <https://reviews.apache.org/r/20636/#comment74813> Unused import core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java <https://reviews.apache.org/r/20636/#comment74814> Unused imports core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java <https://reviews.apache.org/r/20636/#comment74815> missing @Override - Christopher Tubbs On April 24, 2014, 4:54 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20636/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 4:54 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2726 > https://issues.apache.org/jira/browse/ACCUMULO-2726 > > > Repository: accumulo > > > Description > ------- > > restores things found missing by japi compliance checker > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java > 9c39ea6 > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java > 30e47af > > core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java > f80eee5 > > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java > b9a7791 > > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java > 569a3b6 > > core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java > 9d662f4 > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java > 843f572 > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java > 3d69cc1 > > core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java > 7d9d3ab > > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java > 996198c > > core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java > 15379af > > core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java > 9f0594a > > core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java > 16a8e02 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java > 2bc9436 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java > d3b1571 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java > 6bd01a9 > core/src/main/java/org/apache/accumulo/core/security/Credentials.java > 5afc6e8 > > core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java > 32136a8 > > core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java > PRE-CREATION > core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java > 4f8079e > > server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java > c2a7001 > > server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java > d63a63e > > server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java > cd59b78 > test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f > test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 > > Diff: https://reviews.apache.org/r/20636/diff/ > > > Testing > ------- > > unit tests pass. ITs passed. > > > Thanks, > > Sean Busbey > >
