> On April 24, 2014, 10:14 p.m., Christopher Tubbs wrote: > > core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java, > > line 62 > > <https://reviews.apache.org/r/20636/diff/5/?file=568074#file568074line62> > > > > This should use Constants.UTF8.name() (StandardCharsets.UTF_8.name() > > for merge to master)
missed specifying a charset at all on the setWriter method! - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20636/#review41403 ----------------------------------------------------------- On April 24, 2014, 8:54 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20636/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 8:54 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2726 > https://issues.apache.org/jira/browse/ACCUMULO-2726 > > > Repository: accumulo > > > Description > ------- > > restores things found missing by japi compliance checker > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java > 9c39ea6 > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java > 30e47af > > core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java > f80eee5 > > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java > b9a7791 > > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java > 569a3b6 > > core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java > 9d662f4 > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java > 843f572 > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java > 3d69cc1 > > core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java > 7d9d3ab > > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java > 996198c > > core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java > 15379af > > core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java > 9f0594a > > core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java > 16a8e02 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java > 2bc9436 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java > d3b1571 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java > 6bd01a9 > core/src/main/java/org/apache/accumulo/core/security/Credentials.java > 5afc6e8 > > core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java > 32136a8 > > core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java > PRE-CREATION > core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java > 4f8079e > > server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java > c2a7001 > > server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java > d63a63e > > server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java > cd59b78 > test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f > test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 > > Diff: https://reviews.apache.org/r/20636/diff/ > > > Testing > ------- > > unit tests pass. ITs passed. > > > Thanks, > > Sean Busbey > >
