> On April 28, 2014, 4:57 p.m., Christopher Tubbs wrote: > > core/src/test/java/org/apache/accumulo/core/util/shell/command/HistoryCommandTest.java, > > lines 76-81 > > <https://reviews.apache.org/r/20790/diff/2/?file=569586#file569586line76> > > > > This test fails.
I should have clarified. The assertion fails. The test does not throw an exception. The value of baos.toString().trim() appears to be the empty string. - Christopher ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20790/#review41635 ----------------------------------------------------------- On April 28, 2014, 3:40 p.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20790/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 3:40 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2742 > https://issues.apache.org/jira/browse/ACCUMULO-2742 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2742 offset history command by one > > The history entries returned by the history command are 0-indexed, > while the history expansion is 1-indexed. We need to offset the index > when we print it so that users can accurately use event expansion. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/util/shell/commands/HistoryCommand.java > 9531d903aca834ab3b70650824023061e7e788d9 > > core/src/test/java/org/apache/accumulo/core/util/shell/command/HistoryCommandTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/20790/diff/ > > > Testing > ------- > > New unit test. Verified on cluster deployment. > > > Thanks, > > Mike Drob > >
