> On May 9, 2014, 5:46 p.m., Sean Busbey wrote: > > I don't see any tests to cover the non-blocking server. Could we add > > something?
We already have comprehensive test coverage of the thrift server, from all of our RPC calls. What additional coverage do you think is needed? For my purposes, I think a test that fails if the Thrift version is ever switched to something other than 0.9.1 would be sufficient, to ensure we revisit this. - Christopher ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21043/#review42612 ----------------------------------------------------------- On May 2, 2014, 7:15 p.m., Christopher Tubbs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21043/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 7:15 p.m.) > > > Review request for accumulo, Sean Busbey and kturner. > > > Bugs: ACCUMULO-1691 > https://issues.apache.org/jira/browse/ACCUMULO-1691 > > > Repository: accumulo > > > Description > ------- > > Updates Thrift dependency to 0.9.1 with a hack to access a needed protected > field. > > > Diffs > ----- > > pom.xml 43aa5fb > > server/base/src/main/java/org/apache/accumulo/server/util/CustomNonBlockingServer.java > PRE-CREATION > server/base/src/main/java/org/apache/accumulo/server/util/TServerUtils.java > 6d9e4c7 > > Diff: https://reviews.apache.org/r/21043/diff/ > > > Testing > ------- > > mvn clean verify -Psunny > > > Thanks, > > Christopher Tubbs > >
