----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21169/#review42423 -----------------------------------------------------------
LocalWALRecovery would be a better name. I've run into several users who get things confused with application logs when we refer to things simply as "log". server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalLogRecovery.java <https://reviews.apache.org/r/21169/#comment76198> If we keep the deletion, this needs to call out that that happens. If we don't, it should include brief "and then delete the local files" instructions. Giving some idea of the maximum memory needed by this tool would be nice. Also a usage message that gives the utility description that's in the javadocs would be nice. server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalLogRecovery.java <https://reviews.apache.org/r/21169/#comment76188> We're lucky it's here, but does anyone know why this property is still present in 1.6? since the Logger role doesn't exist anymore, we should make sure there's at least a comment about it needing to stick around for this utility. Or maybe we should remove the property and this should be a command line arg? server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalLogRecovery.java <https://reviews.apache.org/r/21169/#comment76190> if someone is using this utility, I'd expect this would inidicate a misconfiguration at least worthy of WARN. server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalLogRecovery.java <https://reviews.apache.org/r/21169/#comment76191> if someone is using this utility, I'd expect this would inidicate a misconfiguration at least worthy of WARN. server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalLogRecovery.java <https://reviews.apache.org/r/21169/#comment76193> Since this is a utility geared towards use after there's been some kind of failure, I'd rather see this deletion handled manually by the operator. Esp since we're talking about local filesystem files where things like the HDFS Trash can't protect operators. Maybe add a --delete-local-files flag to optionally take care of the cleanup? - Sean Busbey On May 7, 2014, 6:38 p.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21169/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 6:38 p.m.) > > > Review request for accumulo, Sean Busbey and Eric Newton. > > > Bugs: ACCUMULO-2770 > https://issues.apache.org/jira/browse/ACCUMULO-2770 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2770 Add utility to read local WAL > > Forward port the upgrade code from 1.5.x into a separate utility so > that a user can still read local WALs if they happen to be around. > > commit 2db5ce6186e32c451328154b024951cc5090505f > Author: Eric C. Newton <e...@apache.org> > Date: Tue Jun 5 13:18:22 2012 +0000 > > > Diffs > ----- > > > server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalLogRecovery.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/21169/diff/ > > > Testing > ------- > > > Thanks, > > Mike Drob > >
