> On July 15, 2014, 6:57 p.m., Mike Drob wrote: > > core/src/main/java/org/apache/accumulo/core/iterators/IteratorUtil.java, > > lines 63-75 > > <https://reviews.apache.org/r/23517/diff/1/?file=632700#file632700line63> > > > > Should this just be an EnumMap that we populate at start-up?
I had placed these in a static-final Map, initialized in a static block, but it appeared that the Property values were not being initialized and ended up being null when I accessed the Map. Wasn't really sure what was going on, tbh, but for 3 elements in the enum (that have no sign of changing), I didn't find this to be too smelly. - Josh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23517/#review47794 ----------------------------------------------------------- On July 15, 2014, 6:51 p.m., Josh Elser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23517/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 6:51 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2994 > https://issues.apache.org/jira/browse/ACCUMULO-2994 > > > Repository: accumulo > > > Description > ------- > > Limits the scope of configuration elements read to only those > iterator-relevant keys that are for the given scope. Reduces unnecessary > processing in creating iterators. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/Property.java d8f9beb > core/src/main/java/org/apache/accumulo/core/iterators/IteratorUtil.java > 1d58c2f > core/src/test/java/org/apache/accumulo/core/iterators/IterUtilTest.java > e569ea4 > core/src/test/java/org/apache/accumulo/core/iterators/IteratorUtilTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23517/diff/ > > > Testing > ------- > > Unit tests for 1.5. Will merge up to 1.6 to run the ITs as well. > > > Thanks, > > Josh Elser > >
