> On July 12, 2014, 3:05 a.m., Christopher Tubbs wrote: > > server/base/src/main/java/org/apache/accumulo/server/Accumulo.java, lines > > 58-60 > > <https://reviews.apache.org/r/23413/diff/1/?file=628539#file628539line58> > > > > I'd think this method could just be dropped in favor of the new one. Is > > there any reason we'd still call this?
My guess is @mdrob didn't want to figure out where it might be used since it's public. Leaving it in will help minimize code signature churn, esp if we update our upgrade process later to not allow multiple versions. Okay to fix in a follow on jira? - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23413/#review47681 ----------------------------------------------------------- On July 11, 2014, 7:19 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23413/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 7:19 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2988 > https://issues.apache.org/jira/browse/ACCUMULO-2988 > > > Repository: accumulo > > > Description > ------- > > forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, > as well as new additions. > > > Diffs > ----- > > README c2c2446dc0312c64427c2d7205056c72b2cfdec2 > server/base/src/main/java/org/apache/accumulo/server/Accumulo.java > 68d862d5baaad04ff38789155c0fb60ac18f92b8 > server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java > b577abbb72c9dce70b8f12dfefe381d38c48cb8e > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > 374017d6544a3be5bccb70eab7a994a92f9693ac > server/master/src/main/java/org/apache/accumulo/master/Master.java > c367ae0c2febbb297924da4a87ef1d91104d94c4 > > Diff: https://reviews.apache.org/r/23413/diff/ > > > Testing > ------- > > ran through test upgrade > > * Install 1.4.5 > * Load a variety of table storage configs, each wi/156M cells (~4GB > uncompressed) > ** no compression, bloom filter on, block cache on > ** lzo compression, bloom filter off, block cache off > ** snappy compression, bloom filters on, block cache off > ** snappy compression, bloom filters off, block cache on > * Upgrade according to README to 1.6.1-SNAP+patches > * Verify correct contents readable > * force compaction > * restart cluster > * Verify correct contents readable > > > Thanks, > > Sean Busbey > >
