> On Aug. 18, 2014, 3:17 p.m., Josh Elser wrote: > > server/src/test/java/org/apache/accumulo/server/tabletserver/InMemoryMapTest.java, > > line 261 > > <https://reviews.apache.org/r/24741/diff/1/?file=661486#file661486line261> > > > > There's no '3' case for interleaving. Was that intentional like the '0' > > case?
that was not intentional. I will fix that. > On Aug. 18, 2014, 3:17 p.m., Josh Elser wrote: > > server/src/test/java/org/apache/accumulo/server/tabletserver/InMemoryMapTest.java, > > line 243 > > <https://reviews.apache.org/r/24741/diff/1/?file=661486#file661486line243> > > > > Would be better to use something like > > > > System.getProperty("user.dir") + "/target > > > > instead of "/tmp" that would be a nice change, I'll do that. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24741/#review50882 ----------------------------------------------------------- On Aug. 15, 2014, 4:31 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24741/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 4:31 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1628 > https://issues.apache.org/jira/browse/ACCUMULO-1628 > > > Repository: accumulo > > > Description > ------- > > Bug fix for ACCUMULO-1628. If no activity on review by 8/20 I will push > patch. > > I was concerned about the case where two threads will concurrently switch > different deep copies. There is the scan thread and the thread deleting in > mem map and calling switchNow on each deepCopy. Access to each deep copy is > synchronized, so thats fine. This patch modified the deep copies to use a > shared rfile. I think deep copy of the shared rfile is synchronized > properly. The shared rfile was introduced to get around problems with the > temp file being deleted. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java > a4970dc > > server/src/main/java/org/apache/accumulo/server/tabletserver/InMemoryMap.java > 914cd85 > > server/src/test/java/org/apache/accumulo/server/tabletserver/InMemoryMapTest.java > 97c8eec > > Diff: https://reviews.apache.org/r/24741/diff/ > > > Testing > ------- > > A unit test was added that reproduced the bug. After changes in patch, unit > test no longer reproduces bug. > > mvn package runs w/o a problem > > > Thanks, > > kturner > >
