----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/#review55498 -----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java <https://reviews.apache.org/r/26188/#comment95884> I don't think this method should be deprecated. Its probably the most commonly used create table call. Also its still useful in the case where a user wants default config. core/src/main/java/org/apache/accumulo/core/client/impl/NewTableConfiguration.java <https://reviews.apache.org/r/26188/#comment95885> Could init this to DEFAULT_TIME_TYPE instead of null and remove the null check in get. core/src/main/java/org/apache/accumulo/core/client/impl/NewTableConfiguration.java <https://reviews.apache.org/r/26188/#comment95886> Could add a check to ensure no null. core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java <https://reviews.apache.org/r/26188/#comment95887> Is there a benefit to deprecating here if its deprecated in the parent class? I am not sure if its needed, does the deprecated annotation inherit? test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java <https://reviews.apache.org/r/26188/#comment95888> Time type is not a property of the table. Its stored in the metadata table. Would need to scan the metadata table for the table and verify the time column value has a prefix of L. Still good to compare props also. Did you plan to change the proxy API and/or create table command in shell? - kturner On Oct. 3, 2014, 5:30 p.m., Jenna Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26188/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 5:30 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3176 > https://issues.apache.org/jira/browse/ACCUMULO-3176 > > > Repository: accumulo > > > Description > ------- > > Gives the ability to add properties to tables before they are initialized. > Therefore these properties will take effect before the default tablet is > created. We create a NewTableConfiguration class and send that in the create > method as opposed to adding another method. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java > 97f538d > > core/src/main/java/org/apache/accumulo/core/client/impl/NewTableConfiguration.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java > e46b9c9 > core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java > 32dbb28 > core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java > 35cbdd2 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java > 08750fe > > core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java > 02838ed > proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add > > shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java > 81b39d2 > > test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/26188/diff/ > > > Testing > ------- > > New IT, ran unit test and integration tests > > > Thanks, > > Jenna Huston > >
