> On Oct. 21, 2014, 4:21 p.m., kturner wrote: > > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java, line > > 167 > > <https://reviews.apache.org/r/26943/diff/1/?file=725844#file725844line167> > > > > why avoid sleeping before retry in this case?
The sleep happens down below in the call to wait() - Josh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26943/#review57590 ----------------------------------------------------------- On Oct. 20, 2014, 4:28 p.m., Josh Elser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26943/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 4:28 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3242 > https://issues.apache.org/jira/browse/ACCUMULO-3242 > > > Repository: accumulo > > > Description > ------- > > We didn't do some things correctly WRT zookeeper retries. Attempt to make it > better. Made a review in case people want to give some feedback > > > Diffs > ----- > > fate/src/main/java/org/apache/accumulo/fate/zookeeper/IZooReaderWriter.java > afc2250 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/Retry.java 4a37172 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/RetryFactory.java > 3fcb738 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java d9eb243 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReader.java > 994f395 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReaderWriter.java > b29b88a > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooUtil.java e0d8831 > fate/src/test/java/org/apache/accumulo/fate/zookeeper/RetryTest.java > PRE-CREATION > > fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooReaderWriterTest.java > PRE-CREATION > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > 5cbffc3 > > server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKPermHandler.java > 3cac2e9 > > Diff: https://reviews.apache.org/r/26943/diff/ > > > Testing > ------- > > UTs/ITs > > > Thanks, > > Josh Elser > >
