----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27106/ -----------------------------------------------------------
(Updated Nov. 6, 2014, 11:20 p.m.) Review request for accumulo and Eric Newton. Repository: accumulo Description (updated) ------- Main diff is ACCUMULO-898-5.patch. This patch could stand alone. The file attached does a lot of additional refactoring, removing or deprecating everything in the trace module. So we can decide whether to apply just the first patch or both. Diffs (updated) ----- assemble/bin/stop-all.sh 4bf06c0 assemble/pom.xml 89a3747 assemble/src/main/assemblies/component.xml 599d26c core/pom.xml 10e7d71 core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d core/src/main/java/org/apache/accumulo/core/conf/Property.java a558760 core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535 core/src/main/java/org/apache/accumulo/core/trace/AsyncSpanReceiver.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26 core/src/main/java/org/apache/accumulo/core/trace/SendSpansViaThrift.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9 core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 9586eaa core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567 docs/src/main/asciidoc/chapters/administration.txt d5e73f0 docs/src/main/resources/distributedTracing.html 54c9095 examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263 minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb pom.xml ebc2f2f server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 5c93a53 server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 45e883d server/base/src/main/java/org/apache/accumulo/server/trace/TraceFSDataInputStream.java 5162e01 server/base/src/main/java/org/apache/accumulo/server/trace/TraceFileSystem.java d3fbad7 server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 6c7fd47 server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531 server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java f943ac1 server/master/src/main/java/org/apache/accumulo/master/Master.java e3fc69d server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743 server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 49bb56d server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201 server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434 server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 4858b8a server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java f7bda49 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 54c75f8 server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java ef3a0c9 shell/src/main/java/org/apache/accumulo/shell/Shell.java a0ff17a shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570 test/src/main/java/org/apache/accumulo/test/TestIngest.java 7f6c514 test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4 test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 4d9d479 test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 80ee990 test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057 test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java 03677f4 trace/pom.xml aacfb56 trace/src/main/java/org/apache/accumulo/trace/instrument/CloudtraceSpan.java PRE-CREATION trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174 trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4 trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1 trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39 trace/src/main/java/org/apache/accumulo/trace/instrument/TraceProxy.java cb93210 trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d trace/src/main/java/org/apache/accumulo/trace/instrument/Tracer.java d70aeea trace/src/main/java/org/apache/accumulo/trace/instrument/impl/MilliSpan.java b641a2c trace/src/main/java/org/apache/accumulo/trace/instrument/impl/NullSpan.java 916b6cf trace/src/main/java/org/apache/accumulo/trace/instrument/impl/RootMilliSpan.java c25e644 trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69 trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/LogSpans.java dfed660 trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97 trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/ZooSpanClient.java 84e3204 trace/src/main/java/org/apache/accumulo/trace/thrift/Annotation.java PRE-CREATION trace/src/main/java/org/apache/accumulo/trace/thrift/RemoteSpan.java 416ae17 trace/src/main/thrift/trace.thrift 76bcafe trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8 Diff: https://reviews.apache.org/r/27106/diff/ Testing ------- File Attachments (updated) ---------------- ACCUMULO-898-5-additional-refactoring.patch https://reviews.apache.org/media/uploaded/files/2014/11/06/ba7f147e-3918-4376-92ec-6feeb82ef31a__ACCUMULO-898-5-additional-refactoring.patch Thanks, Billie Rinaldi
