> On Nov. 10, 2014, 9:38 p.m., Mike Drob wrote: > > test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java, line > > 34 > > <https://reviews.apache.org/r/27829/diff/1/?file=757270#file757270line34> > > > > Plkease add a test that only one recovery will happen at a time. > > Eric Newton wrote: > Any idea how I can do that?
Wrap the actual logic that recover does in some other method (or maybe a runnable) -- the code that runs once the semaphore is acquired. Then, you can use EasyMock to mock that method to alter some external state before calling the real method. Finally, trigger multiple recoveries. After all of the assignments happen, you can verify your external state to ensure that no two recoveries happened concurrently. - Josh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27829/#review60681 ----------------------------------------------------------- On Nov. 10, 2014, 9:11 p.m., Eric Newton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27829/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 9:11 p.m.) > > > Review request for accumulo. > > > Repository: accumulo > > > Description > ------- > > Allow for multiple threads to perform assignment, but use only a single > thread for recovery playback > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/Property.java f59b654 > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java > 1e81947 > > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java > ba86522 > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java > 9490903 > test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27829/diff/ > > > Testing > ------- > > Added an IT that verifies that tablet loading goes faster with more threads. > > > Thanks, > > Eric Newton > >
