> On Dec. 5, 2014, 3:45 p.m., Josh Elser wrote: > > Lots of whitespace nits to resolve (pretty much every file). Need tests (if > > not via the Shell, at least some sort of mock) for all of the options. > > kturner wrote: > I'll wack the whitespace
I added a unit test for the output options and found a bug in the process. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28739/#review63998 ----------------------------------------------------------- On Dec. 5, 2014, 10:43 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28739/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 10:43 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3134 > https://issues.apache.org/jira/browse/ACCUMULO-3134 > > > Repository: accumulo > > > Description > ------- > > Added file selection and output configuration to shell compact command > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/compaction/CompactionSettings.java > PRE-CREATION > > server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategy.java > PRE-CREATION > > server/tserver/src/test/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategyTest.java > PRE-CREATION > shell/src/main/java/org/apache/accumulo/shell/Shell.java 8927ee0 > shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java > 660630e > test/src/test/java/org/apache/accumulo/test/ShellServerIT.java d878c7f > > Diff: https://reviews.apache.org/r/28739/diff/ > > > Testing > ------- > > Added an IT that test file selection options on compact command. IT does not > test output file configuration. > > > Thanks, > > kturner > >
