----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28739/#review64395 -----------------------------------------------------------
Ship it! Thanks for adding the doc, after that minor clarification, it's good to commit IMO. - Josh Elser On Dec. 9, 2014, 5:32 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28739/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 5:32 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3134 > https://issues.apache.org/jira/browse/ACCUMULO-3134 > > > Repository: accumulo > > > Description > ------- > > Added file selection and output configuration to shell compact command > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/compaction/CompactionSettings.java > PRE-CREATION > > server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategy.java > PRE-CREATION > > server/tserver/src/test/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategyTest.java > PRE-CREATION > shell/src/main/java/org/apache/accumulo/shell/Shell.java 8927ee0 > shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java > 660630e > test/src/test/java/org/apache/accumulo/test/ShellServerIT.java d878c7f > > Diff: https://reviews.apache.org/r/28739/diff/ > > > Testing > ------- > > Added an IT that test file selection options on compact command. IT does not > test output file configuration. > > > Thanks, > > kturner > >
