----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/#review66493 -----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/client/ScannerBase.java <https://reviews.apache.org/r/29502/#comment110073> Testing this method for scanner and batch scanner would be nice. core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReader.java <https://reviews.apache.org/r/29502/#comment110070> was putting @Override on same line as method decleration intentional? test/src/test/java/org/apache/accumulo/test/ScanIteratorIT.java <https://reviews.apache.org/r/29502/#comment110071> could this be more strict, should the count be 1? test/src/test/java/org/apache/accumulo/test/ScanIteratorIT.java <https://reviews.apache.org/r/29502/#comment110072> Two more test would be nice. * Test the case where empty set of Auths is set on scanner, and verify AuthsIterator.FAIL is returned. * Test case where set Auths("B") is set on scanner, and verify AuthsIterator.FAIL is returned. The TransformingIterator could possible be modified to leverage this change. That could be done as a follow on issue. - kturner On Dec. 31, 2014, 3:40 p.m., Corey Nolet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29502/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2014, 3:40 p.m.) > > > Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and > kturner. > > > Bugs: ACCUMULO-3458 > https://issues.apache.org/jira/browse/ACCUMULO-3458 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-3458 Propagating scan-time authorizations through the > IteratorEnvironment so that scan-time iterators can use them. > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java > 4903656 > core/src/main/java/org/apache/accumulo/core/client/ScannerBase.java 335b63a > core/src/main/java/org/apache/accumulo/core/client/impl/OfflineScanner.java > 2552682 > core/src/main/java/org/apache/accumulo/core/client/impl/ScannerImpl.java > 666a8af > core/src/main/java/org/apache/accumulo/core/client/impl/ScannerOptions.java > 9726266 > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReader.java > 2a79f05 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockScannerBase.java > 72cb863 > > core/src/main/java/org/apache/accumulo/core/iterators/IteratorEnvironment.java > 9e20cb1 > > core/src/main/java/org/apache/accumulo/core/iterators/system/VisibilityFilter.java > 15c33fa > > core/src/test/java/org/apache/accumulo/core/iterators/DefaultIteratorEnvironment.java > 94da7b5 > > core/src/test/java/org/apache/accumulo/core/iterators/FirstEntryInRowIteratorTest.java > fa46360 > > core/src/test/java/org/apache/accumulo/core/iterators/user/RowDeletingIteratorTest.java > 4521e55 > > core/src/test/java/org/apache/accumulo/core/iterators/user/TransformingIteratorTest.java > 4cebab7 > > server/base/src/test/java/org/apache/accumulo/server/iterators/MetadataBulkLoadFilterTest.java > 4a45e99 > > server/base/src/test/java/org/apache/accumulo/server/replication/StatusCombinerTest.java > a9801b0 > > server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/NullScanner.java > bf35557 > > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java > d1fece5 > > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java > 869cc33 > > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java > fe4b16b > test/src/main/java/org/apache/accumulo/test/functional/AuthsIterator.java > PRE-CREATION > test/src/test/java/org/apache/accumulo/test/ScanIteratorIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29502/diff/ > > > Testing > ------- > > Wrote an integration test to verify that ScanDataSource is actually setting > the authorizations on the IteratorEnvironment > > > Thanks, > > Corey Nolet > >
