> On Dec. 18, 2014, 12:20 p.m., Christopher Tubbs wrote:
> > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java,
> >  line 34
> > <https://reviews.apache.org/r/29176/diff/1/?file=795044#file795044line34>
> >
> >     It'd be neat if there were a MetricsGatherer interface, which this 
> > class implemented. That way, you could register other MetricsGatherers with 
> > the RFile Reader.
> >     
> >     The interface should have javadocs which explain when each method is 
> > expected to be called (e.g., how they are used by RFile).
> 
> Mike Drob wrote:
>     You mean like 
> https://lucene.apache.org/solr/4_10_2/solr-core/org/apache/solr/core/SolrInfoMBean.html?

I don't know what that is for. The updated patch does what I was thinking.


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29176/#review65502
-----------------------------------------------------------


On Dec. 22, 2014, 10:25 a.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29176/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2014, 10:25 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3420
>     https://issues.apache.org/jira/browse/ACCUMULO-3420
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added an option to PrintInfo to get visibility metrics.  Prints the number of 
> times a visibilty is seen in each locality group.  Also shows how many blocks 
> in the locality group have his visibiltiy.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java 
> 43586dd 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 
>   
> core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/accumulo/core/file/rfile/RFileMetricsTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29176/diff/
> 
> 
> Testing
> -------
> 
> Tested with a few RFiles that I made.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>

Reply via email to