-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68522
-----------------------------------------------------------

Ship it!



docs/src/main/latex/accumulo_user_manual/chapters/administration.tex
<https://reviews.apache.org/r/29959/#comment112828>

    nit: you should say what an operator should expect to see from this command 
when it's successful (nothing, IIRC) and maybe what it says if it fails.



server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
<https://reviews.apache.org/r/29959/#comment112827>

    please don't remove the braces for the if statement.


- Sean Busbey


On Jan. 16, 2015, 5:06 a.m., Corey Nolet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 5:06 a.m.)
> 
> 
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and 
> kturner.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as 
> well as an error message when a replaced instance appears in instance.volumes
> 
> 
> Diffs
> -----
> 
>   docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 
> 4b917d1 
>   server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 
> 51fa47e 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 
> e0a3797 
> 
> Diff: https://reviews.apache.org/r/29959/diff/
> 
> 
> Testing
> -------
> 
> Built the manual and found that the page numbers aren't aligning with the 
> table of contents. Opened up ACCUMULO-3486 to address this. Still need to 
> verify if it's a recent bug or if it's been around for awhile.
> 
> Physically tested the error message appears when 'bin/accumulo init 
> --add-volumes' is called and a replaced volume appears in instance.volumes. 
> Also verified that the error does not appear when 'bin/accumulo init 
> --add-volumes' is called and the replaced volume does not appear in 
> instance.volumes
> 
> 
> Thanks,
> 
> Corey Nolet
> 
>

Reply via email to