> On Jan. 26, 2015, 5:15 p.m., kturner wrote: > > test/compat/japi-compliance/japi-accumulo-1.6.2.xml, line 18 > > <https://reviews.apache.org/r/30252/diff/1/?file=833472#file833472line18> > > > > are all of the 1.6.X files the same? Could we make a 1.6 template and > > have sed comment in the readme to generate file for your particular version?
shoot. didn't see this comment before I pushed. The 1.6 xmls are all the same as each other and the 1.5 xmls are all the same as each other as well. I'd prefer to leave them broken out because it means I don't have to copy files when I want to compare e.g. 1.6.1 to 1.6.2. Really, I'd like a script that pulled down artifacts and generated the specific xmls off of templates. - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30252/#review69621 ----------------------------------------------------------- On Jan. 25, 2015, 9:38 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30252/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 9:38 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3531 > https://issues.apache.org/jira/browse/ACCUMULO-3531 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-3531 update japi-compliance-check configs. > > > Diffs > ----- > > test/compat/japi-compliance/README 8715f98109389346cb819f06db95345121f39cab > test/compat/japi-compliance/exclude_classes.txt PRE-CREATION > test/compat/japi-compliance/japi-accumulo-1.5.1.xml PRE-CREATION > test/compat/japi-compliance/japi-accumulo-1.5.2.xml PRE-CREATION > test/compat/japi-compliance/japi-accumulo-1.5.xml > test/compat/japi-compliance/japi-accumulo-1.6.0.xml PRE-CREATION > test/compat/japi-compliance/japi-accumulo-1.6.1.xml PRE-CREATION > test/compat/japi-compliance/japi-accumulo-1.6.2.xml PRE-CREATION > test/compat/japi-compliance/japi-accumulo-1.6.xml > 0403a963dcad11115902ca19b07b6102a74131af > > Diff: https://reviews.apache.org/r/30252/diff/ > > > Testing > ------- > > generated these reports using given xml configs and following the included > instructions in the README. > > > Thanks, > > Sean Busbey > >
